Fix coverage badge permission errors on pull requests#272
Closed
Fix coverage badge permission errors on pull requests#272
Conversation
Co-authored-by: talgalili <976006+talgalili@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test coverage badge permission issues
Fix coverage badge permission errors on pull requests
Jan 17, 2026
|
@talgalili has imported this pull request. If you are a Meta employee, you can view this in D90920671. |
There was a problem hiding this comment.
Pull request overview
This PR fixes permission errors in the coverage workflow that occurred when pull requests attempted to commit the coverage badge file. The workflow is modified to restrict badge generation and commit operations to direct pushes to the main branch only.
Changes:
- Added
github.event_name == 'push'condition to three badge-related steps in the coverage workflow - Coverage tests continue to run on pull requests; only badge commits are gated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coverage workflow attempts to commit the badge file on pull requests to main, which fails with permission errors since PRs run with read-only tokens.
Changes
Added
github.event_name == 'push'check to three conditional steps in.github/workflows/coverage.yml:Badge generation and commit now only execute on direct pushes to main, not on pull requests or manual workflow dispatches.
Tests and coverage reports continue to run on pull requests; only the badge commit step is gated.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.